Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1682763003: Retire temporary cssTextCache() release assert. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
haraken, Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retire temporary cssTextCache() release assert. R= BUG=584692 Committed: https://crrev.com/33b3bdba3bd965119ff9891dccc5d93d65efca26 Cr-Commit-Position: refs/heads/master@{#374611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look. The assert has had a week or two & not shown ...
4 years, 10 months ago (2016-02-09 16:40:16 UTC) #2
Timothy Loh
On 2016/02/09 16:40:16, sof wrote: > please take a look. > > The assert has ...
4 years, 10 months ago (2016-02-09 23:44:41 UTC) #3
haraken
LGTM
4 years, 10 months ago (2016-02-09 23:52:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682763003/1
4 years, 10 months ago (2016-02-10 06:23:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 06:28:07 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 06:28:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33b3bdba3bd965119ff9891dccc5d93d65efca26
Cr-Commit-Position: refs/heads/master@{#374611}

Powered by Google App Engine
This is Rietveld 408576698