Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 1682683002: [InputEvent] Add InputEvent with basic interface behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing layout test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Node.cpp
diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp
index 897430f3629b36d3e6dd7e56c735839b6d37d5f1..31df6e6614094d8b50ba0f40a8acb4902e3c63a2 100644
--- a/third_party/WebKit/Source/core/dom/Node.cpp
+++ b/third_party/WebKit/Source/core/dom/Node.cpp
@@ -65,6 +65,7 @@
#include "core/events/EventDispatcher.h"
#include "core/events/EventListener.h"
#include "core/events/GestureEvent.h"
+#include "core/events/InputEvent.h"
#include "core/events/KeyboardEvent.h"
#include "core/events/MouseEvent.h"
#include "core/events/MutationEvent.h"
@@ -2077,7 +2078,9 @@ void Node::dispatchSimulatedClick(Event* underlyingEvent, SimulatedClickMouseEve
void Node::dispatchInputEvent()
{
- dispatchScopedEvent(Event::createBubble(EventTypeNames::input));
+ InputEventInit eventInitDict;
+ eventInitDict.setBubbles(true);
+ dispatchScopedEvent(InputEvent::create(EventTypeNames::input, eventInitDict));
chongz 2016/02/09 15:35:59 Do we prefer dictionary constructor or classic one
dtapuska 2016/02/09 15:49:11 this is fine I think; less code is often better. I
}
void Node::defaultEventHandler(Event* event)

Powered by Google App Engine
This is Rietveld 408576698