Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 1682673002: Add ./tool/override_analyzer_dependency.sh to checkout latest analyzer + set is as override (Closed)

Created:
4 years, 10 months ago by ochafik
Modified:
4 years, 10 months ago
Reviewers:
vsm, Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ./tool/override_analyzer_dependency.sh to checkout latest analyzer + set is as override Note that pub get is needed after this. When DDC works with analyzer@master, we can setup a travis env by adding the following lines to .travis.yml: before_install: - test -z "$ANALYZER_BRANCH" || ./tool/override_analyzer_dependency.sh env: - ANALYZER_BRANCH="" - ANALYZER_BRANCH="master" Currently the latest analyzer provides null elements for CompilationUnit parts of dart._runtime (see failure: https://travis-ci.org/dart-lang/dev_compiler/jobs/107936636#L465) BUG= R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1a679da972494215f68067ce52f36fd5fcecfaef

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fail on local mods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M .gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
A tool/dependency_overrides.sh View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A tool/override_analyzer_dependency.sh View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ochafik
Hey guys, can't just setup the two travis envs, as latest analyzer doesn't seem to ...
4 years, 10 months ago (2016-02-09 04:11:16 UTC) #2
Leaf
lgtm.
4 years, 10 months ago (2016-02-10 00:48:10 UTC) #3
ochafik
4 years, 10 months ago (2016-02-10 03:09:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1a679da972494215f68067ce52f36fd5fcecfaef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698