tools/rebaseline.py - Issue 16826003: rebaseline.py: keep going if we encounter an "INVALID" entry in the JSON file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/rebaseline.py

Issue 16826003: rebaseline.py: keep going if we encounter an "INVALID" entry in the JSON file (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/rebaseline.py

===================================================================

--- tools/rebaseline.py (revision 9541)

+++ tools/rebaseline.py (working copy)

@@ -140,6 +140,10 @@

print ('# unable to find filename %s in all_results dict' %

infilename)

return False

+ except ValueError as e:

+ print '# ValueError reading filename %s from all_results dict: %s'%(

+ infilename, e)

+ return False

url = '%s/%s/%s/%s.png' % (self._googlestorage_gm_actuals_root,

hash_type, test_name, hash_value)

try:

« no previous file with comments | « no previous file | no next file » | no next file with comments »