third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl - Issue 1682483002: MediaRecorder: remove ASSERTS in bitrate clamping.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

Issue 1682483002: MediaRecorder: remove ASSERTS in bitrate clamping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: philipj@ comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/mediacapture-record/MediaRecorder.html#MediaRecorderOpt ions	5 // https://w3c.github.io/mediacapture-record/MediaRecorder.html#MediaRecorderOpt ions

6	6

7 dictionary MediaRecorderOptions {	7 dictionary MediaRecorderOptions {

8 DOMString mimeType; // Encoding mimeType.	8 DOMString mimeType; // Encoding mimeType.

9	9

10 // TODO(mcasas): Consider changing the following options to signed: https:// github.com/w3c/mediacapture-record/issues/48, and/or using [EnforceRange]/[Clamp ].	10 // TODO(mcasas): Consider changing the following options to signed: https:// github.com/w3c/mediacapture-record/issues/48, and/or using [EnforceRange]/[Clamp ].

11 unsigned long audioBitsPerSecond = 0;	11 unsigned long audioBitsPerSecond;

12 unsigned long videoBitsPerSecond = 0;	12 unsigned long videoBitsPerSecond;

13 unsigned long bitsPerSecond = 0;	13 unsigned long bitsPerSecond;

14 };	14 };

OLD	NEW

« no previous file with comments | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp ('k') | no next file » | no next file with comments »