Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 1682443002: [wasm] Put the condition last in kExprBrIf. (Closed)

Created:
4 years, 10 months ago by binji
Modified:
4 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Put the condition last in kExprBrIf. To bring V8 into line with the proposed design changes in: https://github.com/WebAssembly/design/pull/489 (This CL is forked from https://codereview.chromium.org/1634673002/. That CL doesn't merge cleanly, and I can't update it.) TBR=titzer@chromium.org LOG=Y BUG=chromium:575167 Committed: https://crrev.com/7a004a02da17d784fa5798b427eb209ee67b1a31 Cr-Commit-Position: refs/heads/master@{#33828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -72 lines) Patch
M src/wasm/ast-decoder.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 5 chunks +51 lines, -49 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682443002/1
4 years, 10 months ago (2016-02-08 20:58:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 21:18:47 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7a004a02da17d784fa5798b427eb209ee67b1a31 Cr-Commit-Position: refs/heads/master@{#33828}
4 years, 10 months ago (2016-02-08 21:19:39 UTC) #5
titzer
4 years, 10 months ago (2016-02-09 08:09:46 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698