Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1682423002: Remove WebWaitableEvent and replace it with WaitableEvent. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-worker-reviews_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, falken, f(malita), gavinp+loader_chromium.org, horo+watch_chromium.org, jam, Nate Chapin, jbroman, Justin Novosad, kinuko+worker_chromium.org, kinuko+watch, loading-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, tyoshino+watch_chromium.org, vmpstr+blinkwatch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebWaitableEvent and replace it with WaitableEvent. The abstraction for WaitableEvents was unnecesary since platform can now depend on base. BUG=561879 Committed: https://crrev.com/08e1d0212bd991c794f2c390ce8b1b52517f1044 Cr-Commit-Position: refs/heads/master@{#374938}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits #

Patch Set 3 : Fix android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -286 lines) Patch
M content/child/blink_platform_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/child/blink_platform_impl.cc View 3 chunks +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserThread.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserThread.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 6 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 16 chunks +17 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandleTest.cpp View 8 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/WaitableEvent.h View 1 2 chunks +28 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/platform/WaitableEvent.cpp View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 52 chunks +66 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 2 chunks +0 lines, -14 lines 0 comments Download
D third_party/WebKit/public/platform/WebWaitableEvent.h View 1 chunk +0 lines, -67 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
dtapuska
4 years, 10 months ago (2016-02-10 15:53:07 UTC) #3
Charlie Reis
Code removal in content/ LGTM.
4 years, 10 months ago (2016-02-10 17:03:31 UTC) #4
haraken
LGTM +esprehn for public/. https://codereview.chromium.org/1682423002/diff/1/third_party/WebKit/Source/platform/WaitableEvent.h File third_party/WebKit/Source/platform/WaitableEvent.h (right): https://codereview.chromium.org/1682423002/diff/1/third_party/WebKit/Source/platform/WaitableEvent.h#newcode46 third_party/WebKit/Source/platform/WaitableEvent.h:46: class PLATFORM_EXPORT WaitableEvent { I ...
4 years, 10 months ago (2016-02-11 00:53:52 UTC) #6
esprehn
lgtm, yeah this seems like it belongs in WTF someday. https://codereview.chromium.org/1682423002/diff/1/third_party/WebKit/Source/platform/WaitableEvent.cpp File third_party/WebKit/Source/platform/WaitableEvent.cpp (right): https://codereview.chromium.org/1682423002/diff/1/third_party/WebKit/Source/platform/WaitableEvent.cpp#newcode15 ...
4 years, 10 months ago (2016-02-11 01:01:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682423002/20001
4 years, 10 months ago (2016-02-11 13:56:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/20641)
4 years, 10 months ago (2016-02-11 14:08:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682423002/40001
4 years, 10 months ago (2016-02-11 19:13:30 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-11 19:49:29 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:36:40 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/08e1d0212bd991c794f2c390ce8b1b52517f1044
Cr-Commit-Position: refs/heads/master@{#374938}

Powered by Google App Engine
This is Rietveld 408576698