Fix transitive dependency on generated header in Blink

Fix transitive dependency on generated header in Blink

FontDescription.h includes FontFamilyNames.h, which is a generated header. The
"make_platform_generated" target that generates FontFamilyNames.h correctly
specifies itself as a hard dependency, and the "blink_platform" target that
builds FontDescription.* correctly depends on the former target. However,
FontDescription.h is itself included in other blink_platform headers that
are themselves included by files built as part of other targets (specifically,
the "blink_platform_test_support" target). The blink_platform target thus needs
to export the hard dependency on make_platform_generated onto its own
dependents in order to avoid those dependents potentially being built before
FontFamilyNames.h is generated.

BUG=585386
Committed: https://crrev.com/c53644c354d0c5cce60f24ab11b0180cc555498c
Cr-Commit-Position: refs/heads/master@{#374648}

[blundell, 2016-02-10 10:56:33]

blundell@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-02-10 12:36:06]

lgtm, nice debugging!

Is there a way to not include the generated header in a public header? (Maybe
more a question for the blink folks.) Public generated headers always tend to be
a mess. I guess I'll just ask that on the bug.

Thanks very much for looking into this!

[blundell, 2016-02-10 12:46:33]

On 2016/02/10 12:36:06, Nico wrote:
> lgtm, nice debugging!
> 
> Is there a way to not include the generated header in a public header? (Maybe
> more a question for the blink folks.) Public generated headers always tend to
be
> a mess. I guess I'll just ask that on the bug.
> 
> Thanks very much for looking into this!

Blink is totally outside of my domain :P.

[blundell, 2016-02-10 12:46:40]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2016-02-10 12:46:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1682373003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1682373003/1

[commit-bot: I haz the power, 2016-02-10 12:51:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-10 12:52:54]

Description was changed from

==========
Fix transitive dependency on generated header in Blink

FontDescription.h includes FontFamilyNames.h, which is a generated header. The
"make_platform_generated" target that generates FontFamilyNames.h correctly
specifies itself as a hard dependency, and the "blink_platform" target that
builds FontDescription.* correctly depends on the former target. However,
FontDescription.h is itself included in other blink_platform headers that
are themselves included by files built as part of other targets (specifically,
the "blink_platform_test_support" target). The blink_platform target thus needs
to export the hard dependency on make_platform_generated onto its own
dependents in order to avoid those dependents potentially being built before
FontFamilyNames.h is generated.

BUG=585386
==========

to

==========
Fix transitive dependency on generated header in Blink

FontDescription.h includes FontFamilyNames.h, which is a generated header. The
"make_platform_generated" target that generates FontFamilyNames.h correctly
specifies itself as a hard dependency, and the "blink_platform" target that
builds FontDescription.* correctly depends on the former target. However,
FontDescription.h is itself included in other blink_platform headers that
are themselves included by files built as part of other targets (specifically,
the "blink_platform_test_support" target). The blink_platform target thus needs
to export the hard dependency on make_platform_generated onto its own
dependents in order to avoid those dependents potentially being built before
FontFamilyNames.h is generated.

BUG=585386

Committed: https://crrev.com/c53644c354d0c5cce60f24ab11b0180cc555498c
Cr-Commit-Position: refs/heads/master@{#374648}
==========

[commit-bot: I haz the power, 2016-02-10 12:52:55]

Patchset 1 (id:??) landed as
https://crrev.com/c53644c354d0c5cce60f24ab11b0180cc555498c
Cr-Commit-Position: refs/heads/master@{#374648}