Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1682363002: Remove //device/devices_app. (Closed)

Created:
4 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove //device/devices_app. This change removes the code to create a Mojo app containing device services (currently only USB) and instead makes the Mojo bindings for //device/usb part of that directory. The Mojo service implementation is still in a separate //device/usb/mojo target but this will eventually merge into its parent directory as the Mojo interface becomes the only public interface for //device/usb. BUG=None Committed: https://crrev.com/64c8f4f25d9fbd2233e476d6276b4c63bcc4813c Cr-Commit-Position: refs/heads/master@{#374778}

Patch Set 1 : #

Patch Set 2 : Undo line ending change breaking the patch application. #

Patch Set 3 : Fix merge conflict in web_usb_device_impl.h. #

Patch Set 4 : Add dependency between mojo service impl and the bindings. #

Patch Set 5 : mojom_bindings_generator.gypi moved. #

Patch Set 6 : Remove two files that somehow survived in //device/devices_app. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -3526 lines) Patch
M chrome/browser/BUILD.gn View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/usb/usb_chooser_bubble_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/usb_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/web_usb_permission_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M components/webusb.gypi View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M components/webusb/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/webusb/public/interfaces/webusb_permission_bubble.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/DEPS View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/usb/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/usb/type_converters.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/usb/web_usb_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/usb/web_usb_device_impl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/usb/web_usb_device_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/BUILD.gn View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M device/device_tests.gyp View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
D device/devices_app/BUILD.gn View 1 chunk +0 lines, -77 lines 0 comments Download
D device/devices_app/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D device/devices_app/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D device/devices_app/devices_app.h View 1 chunk +0 lines, -67 lines 0 comments Download
D device/devices_app/devices_app.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D device/devices_app/devices_app.gyp View 1 2 3 4 5 1 chunk +0 lines, -85 lines 0 comments Download
D device/devices_app/devices_apptest.cc View 1 2 3 4 5 1 chunk +0 lines, -55 lines 0 comments Download
D device/devices_app/main.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D device/devices_app/public/cpp/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D device/devices_app/public/cpp/constants.h View 1 chunk +0 lines, -14 lines 0 comments Download
D device/devices_app/public/cpp/constants.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D device/devices_app/public/cpp/devices_app_factory.h View 1 chunk +0 lines, -28 lines 0 comments Download
D device/devices_app/public/cpp/devices_app_factory.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D device/devices_app/usb/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D device/devices_app/usb/device_impl.h View 1 chunk +0 lines, -113 lines 0 comments Download
D device/devices_app/usb/device_impl.cc View 1 chunk +0 lines, -464 lines 0 comments Download
D device/devices_app/usb/device_impl_unittest.cc View 1 chunk +0 lines, -895 lines 0 comments Download
D device/devices_app/usb/device_manager_impl.h View 1 chunk +0 lines, -111 lines 0 comments Download
D device/devices_app/usb/device_manager_impl.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D device/devices_app/usb/device_manager_impl_unittest.cc View 1 chunk +0 lines, -218 lines 0 comments Download
D device/devices_app/usb/fake_permission_provider.h View 1 chunk +0 lines, -44 lines 0 comments Download
D device/devices_app/usb/fake_permission_provider.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D device/devices_app/usb/public/interfaces/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D device/devices_app/usb/public/interfaces/device.mojom View 1 chunk +0 lines, -285 lines 0 comments Download
D device/devices_app/usb/public/interfaces/device_manager.mojom View 1 chunk +0 lines, -47 lines 0 comments Download
D device/devices_app/usb/public/interfaces/permission_provider.mojom View 1 chunk +0 lines, -29 lines 0 comments Download
D device/devices_app/usb/type_converters.h View 1 chunk +0 lines, -134 lines 0 comments Download
D device/devices_app/usb/type_converters.cc View 1 chunk +0 lines, -283 lines 0 comments Download
A device/usb/mojo/BUILD.gn View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A + device/usb/mojo/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A + device/usb/mojo/device_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + device/usb/mojo/device_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + device/usb/mojo/device_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + device/usb/mojo/device_manager_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + device/usb/mojo/device_manager_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + device/usb/mojo/device_manager_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + device/usb/mojo/fake_permission_provider.h View 1 chunk +1 line, -1 line 0 comments Download
A + device/usb/mojo/fake_permission_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + device/usb/mojo/type_converters.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + device/usb/mojo/type_converters.cc View 2 chunks +5 lines, -3 lines 0 comments Download
A + device/usb/public/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/usb/public/interfaces/device.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/usb/public/interfaces/device_manager.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/usb/public/interfaces/permission_provider.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M device/usb/usb.gyp View 1 2 3 4 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Reilly Grant (use Gerrit)
Please take a look. This is a mostly mechanical change that handles the fallout from ...
4 years, 10 months ago (2016-02-10 02:34:08 UTC) #2
jam
lgtm
4 years, 10 months ago (2016-02-10 17:58:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682363002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682363002/100001
4 years, 10 months ago (2016-02-10 21:14:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/178303)
4 years, 10 months ago (2016-02-10 22:00:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682363002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682363002/120001
4 years, 10 months ago (2016-02-10 22:04:51 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 10 months ago (2016-02-10 23:29:33 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:31 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/64c8f4f25d9fbd2233e476d6276b4c63bcc4813c
Cr-Commit-Position: refs/heads/master@{#374778}

Powered by Google App Engine
This is Rietveld 408576698