AVDACodecImages keep a reference to the SurfaceTexture backing them

content/common/gpu/media/avda_shared_state.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/avda_shared_state.h"
 
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/scoped_make_current.h"
 
 namespace content {
 
 AVDASharedState::AVDASharedState()
     : surface_texture_service_id_(0),
       frame_available_event_(false, false),
       surface_texture_is_attached_(false) {}
 
-AVDASharedState::~AVDASharedState() {}
+AVDASharedState::~AVDASharedState() {

[liberato (no reviews please), 2016/02/10 21:05:15]

i think that you have to maintain a list of Textures in the shared state, and
SetUnownedServiceId(0) on each of them.  that can be done without a context.

[watk, 2016/02/11 00:26:51]

Discussed offline that this is not necessary because this destructor will be
invoked after the destructors of all Textures that might refer to it.

+  if (surface_texture_service_id_ != 0 && context_) {

[liberato (no reviews please), 2016/02/10 21:05:15]

it might be worthwhile to pass in the avda's context and surface during
construction, and use it here instead of |context_|.  otherwise, if we never
display a frame, it'll leak a texture since the surface texture won't be
attached.

+    // XXX: This is the wrong context.

[liberato (no reviews please), 2016/02/10 06:39:12]

it's worth a comment that it's a different one that it was created on, but it's
not a bug.  they're guaranteed to be in the same share group, else nothing would
work, so this is fine.

[watk, 2016/02/11 00:26:51]

Ah, that's why everything works, thanks.

+    auto scoped_make_current = make_scoped_ptr(
+        new ui::ScopedMakeCurrent(context_.get(), surface_.get()));
+    glDeleteTextures(1, &surface_texture_service_id_);
+  }
+}
 
 void AVDASharedState::SignalFrameAvailable() {
   frame_available_event_.Signal();
 }
 
 void AVDASharedState::WaitForFrameAvailable() {
   frame_available_event_.Wait();
 }
 
-void AVDASharedState::did_attach_surface_texture() {
+void AVDASharedState::DidAttachSurfaceTexture() {
   context_ = gfx::GLContext::GetCurrent();
   surface_ = gfx::GLSurface::GetCurrent();
   DCHECK(context_);
   DCHECK(surface_);
 
   surface_texture_is_attached_ = true;
 }
 
 }  // namespace content