Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1682223005: Fix compiler error encountered by Flutter (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix compiler error encountered by Flutter ../../dart/runtime/vm/compiler.cc: In member function 'bool dart::CompileParsedFunctionHelper::Compile(dart::CompilationPipeline*)': ../../dart/runtime/vm/compiler.cc:577:8: error: variable 'done' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered] bool done = false; ^ cc1plus: all warnings being treated as errors [2/10/16, 8:41 AM] Ian Hickson (ianh@google.com): building android debug Committed: https://github.com/dart-lang/sdk/commit/9b2de983e6793511dc3d7b5448ff9fbe95665d0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
TBR
4 years, 10 months ago (2016-02-10 16:49:11 UTC) #3
Cutch
Committed patchset #1 (id:1) manually as 9b2de983e6793511dc3d7b5448ff9fbe95665d0c (presubmit successful).
4 years, 10 months ago (2016-02-10 16:49:41 UTC) #5
srdjan
4 years, 10 months ago (2016-02-10 17:17:37 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698