Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1682203002: make test consistent (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

make test consistent Don't pass rand() to a function as a pair of parameters, since the order of evaluation is unknown TBR=robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1682203002 Committed: https://skia.googlesource.com/skia/+/58f4e1d2fd9d730cb207a02e3a60e09e49480d97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M gm/arcto.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682203002/1
4 years, 10 months ago (2016-02-09 21:53:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/58f4e1d2fd9d730cb207a02e3a60e09e49480d97
4 years, 10 months ago (2016-02-09 22:32:45 UTC) #5
robertphillips
4 years, 10 months ago (2016-02-10 12:50:22 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698