runtime/vm/parser.cc - Issue 1682173008: ‘Yield* e' should not access e.current eagerly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 1682173008: ‘Yield* e' should not access e.current eagerly (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/parser.cc

diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc

index bfd9a170e4bcc1af79c38a21a8d4ab0a9a7b6a73..048c1845fe65f1c8c6582179add48a0e3803fe5d 100644

--- a/runtime/vm/parser.cc

+++ b/runtime/vm/parser.cc

@@ -9795,7 +9795,8 @@ AstNode* Parser::ParseYieldStatement() {

AstNode* store_current =

new(Z) InstanceSetterNode(TokenPosition::kNoSource,

iterator,

- String::ZoneHandle(Symbols::Current().raw()),

+ Library::PrivateCoreLibName(

+ Symbols::_current()),

expr);

yield->AddNode(store_current);

if (is_yield_each) {