Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1682173004: Add missing opener frame null check. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
haraken, dcheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing opener frame null check. Opening a new window requires access to the calling window's frame, and isn't supported otherwise. Add missing null check. R= BUG=541010 Committed: https://crrev.com/5f2416819f0b707b0141f37e1b22fbbac44aed5b Cr-Commit-Position: refs/heads/master@{#374912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/frames/open-without-opener-frame-crash.html View 1 chunk +34 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/frames/open-without-opener-frame-crash-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look. Just a null check seems appropriate and doesn't paper over a ...
4 years, 10 months ago (2016-02-11 09:40:52 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-02-11 09:45:31 UTC) #3
dcheng
lgtm
4 years, 10 months ago (2016-02-11 16:18:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682173004/1
4 years, 10 months ago (2016-02-11 16:22:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 16:51:54 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:35:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f2416819f0b707b0141f37e1b22fbbac44aed5b
Cr-Commit-Position: refs/heads/master@{#374912}

Powered by Google App Engine
This is Rietveld 408576698