Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6316)

Unified Diff: chrome/common/variations/variations_util_unittest.cc

Issue 1682163004: Update --force-fieldtrial-params comment to be a little more clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/variations/variations_util_unittest.cc
diff --git a/chrome/common/variations/variations_util_unittest.cc b/chrome/common/variations/variations_util_unittest.cc
index 87d58ad5636acab17cf253f42efc3eaaad40e534..ea7ffc66fefdf5888d8efe897769eecc281417e5 100644
--- a/chrome/common/variations/variations_util_unittest.cc
+++ b/chrome/common/variations/variations_util_unittest.cc
@@ -49,6 +49,13 @@ TEST_F(VariationsUtilTest, AssociateParamsFromString) {
EXPECT_EQ("/", params["a"]);
}
+TEST_F(VariationsUtilTest, AssociateParamsFromStringWithSameStudy) {
+ const std::string kTrialName = "AssociateVariationParams";
+ const std::string kVariationsString =
+ "AssociateVariationParams.A:a/10/b/test,AssociateVariationParams.A:a/%2F";
Mark P 2016/02/10 04:53:41 As the escape string here isn't needed / important
danduong 2016/02/10 18:19:53 Done.
+ ASSERT_FALSE(AssociateParamsFromString(kVariationsString));
+}
+
TEST_F(VariationsUtilTest, AssociateParamsFromFieldTrialConfig) {
const FieldTrialGroupParams array_kFieldTrialConfig_params[] = {{"x", "1"},
{"y", "2"}};
« chrome/common/variations/variations_util.cc ('K') | « chrome/common/variations/variations_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698