Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2158)

Unified Diff: remoting/client/touch_input_scaler.cc

Issue 1682133002: Remove touch size clamping TODO (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/touch_input_scaler.cc
diff --git a/remoting/client/touch_input_scaler.cc b/remoting/client/touch_input_scaler.cc
index 80c749cc1d74b7978e945a1e416b437b64c86cf0..547314c8a27570dec232d8dc52d28195b5f498f1 100644
--- a/remoting/client/touch_input_scaler.cc
+++ b/remoting/client/touch_input_scaler.cc
@@ -69,8 +69,9 @@ void TouchInputScaler::InjectTouchEvent(const TouchEvent& event) {
// This is because a HiDPI Chromebook device (e.g. Pixel) has 2 by 2
// physical pixel mapped to a logical pixel.
// With scaling, the size would be the same.
- // TODO(rkuroiwa): Also clamp. Note that point->angle() affects the maximum
- // size (crbug.com/461526).
+ // Note that there's no need to clamp the touch point size. For example on
+ // a Nexus4 device, part of the touch circle falls outside the screen on
+ // edges but still functions correctly.
if (point->has_radius_x() || point->has_radius_y()) {
DCHECK(point->has_radius_x() && point->has_radius_y());
point->set_radius_x(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698