Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: shell/application_manager/application_manager.h

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/view_manager/view_tree_host_impl.cc ('k') | shell/application_manager/application_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/application_manager/application_manager.h
diff --git a/shell/application_manager/application_manager.h b/shell/application_manager/application_manager.h
index b5771809d5bc41028d6264d0067c3df28a08479a..72cc947547e1faa3d4e90b6dfd587f5b2a9b93e4 100644
--- a/shell/application_manager/application_manager.h
+++ b/shell/application_manager/application_manager.h
@@ -81,7 +81,7 @@ class ApplicationManager {
const GURL& application_url,
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services,
+ mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,
const base::Closure& on_application_end);
template <typename Interface>
@@ -156,7 +156,7 @@ class ApplicationManager {
const GURL& application_url,
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services,
+ mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,
const base::Closure& on_application_end,
const std::vector<std::string>& pre_redirect_parameters);
@@ -164,13 +164,13 @@ class ApplicationManager {
const GURL& resolved_url,
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider>* services,
- mojo::ServiceProviderPtr* exposed_services);
+ mojo::InterfaceHandle<mojo::ServiceProvider>* exposed_services);
bool ConnectToApplicationWithLoader(
const GURL& resolved_url,
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider>* services,
- mojo::ServiceProviderPtr* exposed_services,
+ mojo::InterfaceHandle<mojo::ServiceProvider>* exposed_services,
const base::Closure& on_application_end,
const std::vector<std::string>& parameters,
ApplicationLoader* loader);
@@ -188,22 +188,23 @@ class ApplicationManager {
const GURL& resolved_url,
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services,
+ mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,
const base::Closure& on_application_end,
const std::vector<std::string>& parameters);
ShellImpl* GetShellImpl(const GURL& url);
- void ConnectToClient(ShellImpl* shell_impl,
- const GURL& resolved_url,
- const GURL& requestor_url,
- mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services);
+ void ConnectToClient(
+ ShellImpl* shell_impl,
+ const GURL& resolved_url,
+ const GURL& requestor_url,
+ mojo::InterfaceRequest<mojo::ServiceProvider> services,
+ mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services);
void HandleFetchCallback(
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services,
+ mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,
const base::Closure& on_application_end,
const std::vector<std::string>& parameters,
scoped_ptr<Fetcher> fetcher);
« no previous file with comments | « services/ui/view_manager/view_tree_host_impl.cc ('k') | shell/application_manager/application_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698