Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: services/gles2/command_buffer_impl.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/gles2/command_buffer_impl.h ('k') | services/http_server/http_server_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/gles2/command_buffer_impl.cc
diff --git a/services/gles2/command_buffer_impl.cc b/services/gles2/command_buffer_impl.cc
index f999c8e1bedb0e27d0cb8bc2e6c9b7394b2614d7..db1f677388375a2fe500fe3cd917fdb88d9ce5e4 100644
--- a/services/gles2/command_buffer_impl.cc
+++ b/services/gles2/command_buffer_impl.cc
@@ -4,6 +4,8 @@
#include "services/gles2/command_buffer_impl.h"
+#include <utility>
+
#include "base/bind.h"
#include "base/message_loop/message_loop.h"
#include "gpu/command_buffer/service/sync_point_manager.h"
@@ -42,7 +44,7 @@ class CommandBufferDriverClientImpl : public CommandBufferDriver::Client {
base::WeakPtr<CommandBufferImpl> command_buffer_;
scoped_refptr<base::SingleThreadTaskRunner> control_task_runner_;
};
-}
+} // namespace
CommandBufferImpl::CommandBufferImpl(
mojo::InterfaceRequest<mojo::CommandBuffer> request,
@@ -72,11 +74,12 @@ CommandBufferImpl::~CommandBufferImpl() {
}
void CommandBufferImpl::Initialize(
- mojo::CommandBufferSyncClientPtr sync_client,
- mojo::CommandBufferSyncPointClientPtr sync_point_client,
- mojo::CommandBufferLostContextObserverPtr loss_observer,
+ mojo::InterfaceHandle<mojo::CommandBufferSyncClient> sync_client,
+ mojo::InterfaceHandle<mojo::CommandBufferSyncPointClient> sync_point_client,
+ mojo::InterfaceHandle<mojo::CommandBufferLostContextObserver> loss_observer,
mojo::ScopedSharedBufferHandle shared_state) {
- sync_point_client_ = sync_point_client.Pass();
+ sync_point_client_ = mojo::CommandBufferSyncPointClientPtr::Create(
+ std::move(sync_point_client));
driver_task_runner_->PostTask(
FROM_HERE,
base::Bind(&CommandBufferDriver::Initialize,
« no previous file with comments | « services/gles2/command_buffer_impl.h ('k') | services/http_server/http_server_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698