services/gfx/compositor/compositor_impl.h - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/gfx/compositor/compositor_impl.h

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/gfx/compositor/compositor_impl.h

diff --git a/services/gfx/compositor/compositor_impl.h b/services/gfx/compositor/compositor_impl.h

index 78e35adc6cf7d3ab0cce24e6ef387efdbc5d8441..fd5956fd79811ce2d2ce101fe020f1e51929ab9a 100644

--- a/services/gfx/compositor/compositor_impl.h

+++ b/services/gfx/compositor/compositor_impl.h

@@ -25,7 +25,7 @@ class CompositorImpl : public mojo::gfx::composition::Compositor {

const mojo::String& label,

const CreateSceneCallback& callback) override;

void CreateRenderer(

- mojo::ContextProviderPtr context_provider,

+ mojo::InterfaceHandle<mojo::ContextProvider> context_provider,

mojo::InterfaceRequest<mojo::gfx::composition::Renderer> renderer_request,

const mojo::String& label) override;

« no previous file with comments | « services/gfx/compositor/compositor_engine.cc ('k') | services/gfx/compositor/compositor_impl.cc » ('j') | no next file with comments »