Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: services/dart/dart_tracing.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/dart/dart_tracing.h ('k') | services/gfx/compositor/backend/gpu_output.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/dart/dart_tracing.cc
diff --git a/services/dart/dart_tracing.cc b/services/dart/dart_tracing.cc
index d3c435331814f924491fa5f00daad820634955c1..0ff1b4daa5e2e61f9e4db37b108c0b45637f3b2d 100644
--- a/services/dart/dart_tracing.cc
+++ b/services/dart/dart_tracing.cc
@@ -4,6 +4,8 @@
#include "services/dart/dart_tracing.h"
+#include <utility>
+
#include "dart/runtime/include/dart_tools_api.h"
#include "mojo/public/cpp/application/application_impl.h"
@@ -44,10 +46,11 @@ void DartTraceProvider::Bind(
}
// tracing::TraceProvider implementation:
-void DartTraceProvider::StartTracing(const mojo::String& categories,
- tracing::TraceRecorderPtr recorder) {
+void DartTraceProvider::StartTracing(
+ const mojo::String& categories,
+ mojo::InterfaceHandle<tracing::TraceRecorder> recorder) {
DCHECK(!recorder_.get());
- recorder_ = recorder.Pass();
+ recorder_ = tracing::TraceRecorderPtr::Create(std::move(recorder));
DartTimelineController::Enable(categories);
}
« no previous file with comments | « services/dart/dart_tracing.h ('k') | services/gfx/compositor/backend/gpu_output.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698