mojo/ui/view_provider_app.h - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/ui/view_provider_app.h

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/ui/view_provider_app.h

diff --git a/mojo/ui/view_provider_app.h b/mojo/ui/view_provider_app.h

index f5c4b355659bf5ded0df6f65d4ed9fef1de998a9..ff174f551687268bdf07355a16417340a9021809 100644

--- a/mojo/ui/view_provider_app.h

+++ b/mojo/ui/view_provider_app.h

@@ -54,7 +54,7 @@ class ViewProviderApp : public mojo::ApplicationDelegate,

const std::string& view_provider_url,

mojo::InterfaceRequest<mojo::ui::ViewOwner> view_owner_request,

mojo::InterfaceRequest<mojo::ServiceProvider> services,

- mojo::ServiceProviderPtr exposed_services) = 0;

+ mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services) = 0;

private:

class DelegatingViewProvider;

@@ -68,7 +68,7 @@ class ViewProviderApp : public mojo::ApplicationDelegate,

const std::string& view_provider_url,

mojo::InterfaceRequest<mojo::ui::ViewOwner> view_owner_request,

mojo::InterfaceRequest<mojo::ServiceProvider> services,

- mojo::ServiceProviderPtr exposed_services);

+ mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services);

mojo::ApplicationImpl* app_impl_ = nullptr;

mojo::StrongBindingSet<mojo::ui::ViewProvider> bindings_;

« no previous file with comments | « mojo/ui/gl_renderer_unittest.cc ('k') | mojo/ui/view_provider_app.cc » ('j') | no next file with comments »