mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/handle_passing_unittest.cc ('k') | mojo/public/cpp/bindings/tests/sample_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc b/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

index e0a21c76b0faac9282ea735c1ef88aacd4603824..dc8e290302967a4ff9b7ddcbad6caf7d0adf75e1 100644

--- a/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

@@ -153,7 +153,7 @@ class ReentrantServiceImpl : public sample::Service {

void Frobinate(sample::FooPtr foo,

sample::Service::BazOptions baz,

- sample::PortPtr port,

+ mojo::InterfaceHandle<sample::Port> port,

const sample::Service::FrobinateCallback& callback) override {

max_call_depth_ = std::max(++call_depth_, max_call_depth_);

if (call_depth_ == 1) {