mojo/public/cpp/application/lib/service_registry.h - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/application/lib/service_registry.h

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/application/lib/application_test_base.cc ('k') | mojo/public/cpp/application/lib/service_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/application/lib/service_registry.h

diff --git a/mojo/public/cpp/application/lib/service_registry.h b/mojo/public/cpp/application/lib/service_registry.h

index de987749a725ba5618526495a6a2f2b6dc70d8cf..975fc213ac38abe0a3662a16c1e55e9dba75bb0d 100644

--- a/mojo/public/cpp/application/lib/service_registry.h

+++ b/mojo/public/cpp/application/lib/service_registry.h

@@ -28,7 +28,7 @@ class ServiceRegistry : public ServiceProvider, public ApplicationConnection {

ServiceRegistry(ApplicationImpl* application_impl,

const std::string& connection_url,

const std::string& remote_url,

- ServiceProviderPtr remote_services,

+ InterfaceHandle<ServiceProvider> remote_services,

InterfaceRequest<ServiceProvider> local_services);

~ServiceRegistry() override;

« no previous file with comments | « mojo/public/cpp/application/lib/application_test_base.cc ('k') | mojo/public/cpp/application/lib/service_registry.cc » ('j') | no next file with comments »