examples/indirect_service/indirect_integer_service.cc - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: examples/indirect_service/indirect_integer_service.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « examples/forwarding_content_handler/forwarding_content_handler.cc ('k') | examples/indirect_service/indirect_service_demo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: examples/indirect_service/indirect_integer_service.cc

diff --git a/examples/indirect_service/indirect_integer_service.cc b/examples/indirect_service/indirect_integer_service.cc

index e4239a99c903fd58780344d272c93c2c3ed044d5..072e9e07313b725c3252faa790f4900d1cd0f49b 100644

--- a/examples/indirect_service/indirect_integer_service.cc

+++ b/examples/indirect_service/indirect_integer_service.cc

@@ -29,8 +29,8 @@ class IndirectIntegerServiceImpl : public IndirectIntegerService,

// IndirectIntegerService

- void Set(IntegerServicePtr service) override {

- integer_service_ = service.Pass();

+ void Set(InterfaceHandle<IntegerService> service) override {

+ integer_service_ = IntegerServicePtr::Create(std::move(service));

}

void Get(InterfaceRequest<IntegerService> service) override {