services/ui/view_manager/view_manager_impl.h - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/view_manager/view_manager_impl.h

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: delay InterfacePtr::Create() until you actually need an InterfacePtr. GetProxy() and ConnectToAppl… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/ui/view_manager/view_manager_impl.h

diff --git a/services/ui/view_manager/view_manager_impl.h b/services/ui/view_manager/view_manager_impl.h

index 89c463feedbe03e0b7399cc58ae4223146d44700..0c7aa1a4db05042eabb59f154dc2d2ca4eca71e9 100644

--- a/services/ui/view_manager/view_manager_impl.h

+++ b/services/ui/view_manager/view_manager_impl.h

@@ -20,12 +20,12 @@ class ViewManagerImpl : public mojo::ui::ViewManager {

private:

// |ViewManager|:

void RegisterView(

- mojo::ui::ViewPtr view,

+ mojo::InterfaceHandle<mojo::ui::View> view,

mojo::InterfaceRequest<mojo::ui::ViewHost> view_host_request,

const mojo::String& label,

const RegisterViewCallback& callback) override;

void RegisterViewTree(

- mojo::ui::ViewTreePtr view_tree,

+ mojo::InterfaceHandle<mojo::ui::ViewTree> view_tree,

mojo::InterfaceRequest<mojo::ui::ViewTreeHost> view_tree_host_request,

const mojo::String& label,

const RegisterViewTreeCallback& callback) override;

« services/http_server/http_server_impl.cc ('K') | « services/ui/input_manager/input_associate.cc ('k') | services/ui/view_manager/view_manager_impl.cc » ('j') | no next file with comments »