services/keyboard/linux/keyboard_service_impl.cc - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/keyboard/linux/keyboard_service_impl.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: delay InterfacePtr::Create() until you actually need an InterfacePtr. GetProxy() and ConnectToAppl… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/keyboard/linux/keyboard_service_impl.cc

diff --git a/services/keyboard/linux/keyboard_service_impl.cc b/services/keyboard/linux/keyboard_service_impl.cc

index f8b6afc2253cbde1070f18d377e0c7bc7a158870..e9fd9eb77cce0560391fadee638dbf1968ed1db5 100644

--- a/services/keyboard/linux/keyboard_service_impl.cc

+++ b/services/keyboard/linux/keyboard_service_impl.cc

@@ -24,9 +24,9 @@ LinuxKeyboardServiceImpl::~LinuxKeyboardServiceImpl() {

}

void LinuxKeyboardServiceImpl::Show(

- keyboard::KeyboardClientPtr client,

+ mojo::InterfaceHandle<keyboard::KeyboardClient> client,

keyboard::KeyboardType type) {

- client_ = client.Pass();

+ client_ = keyboard::KeyboardClientPtr::Create(std::move(client));

}

void LinuxKeyboardServiceImpl::ShowByRequest() {

« services/http_server/http_server_impl.cc ('K') | « services/keyboard/linux/keyboard_service_impl.h ('k') | services/native_support/process_impl.h » ('j') | no next file with comments »