services/gfx/compositor/compositor_engine.cc - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/gfx/compositor/compositor_engine.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: delay InterfacePtr::Create() until you actually need an InterfacePtr. GetProxy() and ConnectToAppl… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/ui/gl_renderer_unittest.cc ('K') | « services/gfx/compositor/compositor_engine.h ('k') | services/gfx/compositor/compositor_impl.h » ('j') | services/gfx/compositor/compositor_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/gfx/compositor/compositor_engine.cc

diff --git a/services/gfx/compositor/compositor_engine.cc b/services/gfx/compositor/compositor_engine.cc

index 8f6990826187d562a0d647e7a76255a37dfe6ba7..448d689b87411e6614b52a8f7648d4728bf7dad9 100644

--- a/services/gfx/compositor/compositor_engine.cc

+++ b/services/gfx/compositor/compositor_engine.cc

@@ -99,7 +99,7 @@ void CompositorEngine::DestroyScene(SceneState* scene_state) {

}

void CompositorEngine::CreateRenderer(

- mojo::ContextProviderPtr context_provider,

+ mojo::InterfaceHandle<mojo::ContextProvider> context_provider,

mojo::InterfaceRequest<mojo::gfx::composition::Renderer> renderer_request,

const mojo::String& label) {

DCHECK(context_provider);