services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: delay InterfacePtr::Create() until you actually need an InterfacePtr. GetProxy() and ConnectToAppl… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/ui/gl_renderer_unittest.cc ('K') | « mojo/ui/view_provider_app.cc ('k') | services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.cc » ('j') | services/gfx/compositor/compositor_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h

diff --git a/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h b/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h

index 2712e0b0e9765f76c7267abf58618defafb89270..62a3d8168b2c5c29789378124992e8bc25651864 100644

--- a/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h

+++ b/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h

@@ -25,7 +25,8 @@ class AuthenticatingURLLoaderInterceptorFactory

public:

AuthenticatingURLLoaderInterceptorFactory(

mojo::InterfaceRequest<URLLoaderInterceptorFactory> request,

- authentication::AuthenticationServicePtr authentication_service,

+ mojo::InterfaceHandle<authentication::AuthenticationService>

+ authentication_service,

mojo::ApplicationImpl* app,

std::map<GURL, std::string>* cached_tokens);

~AuthenticatingURLLoaderInterceptorFactory() override;