mojo/ui/view_provider_app.h - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/ui/view_provider_app.h

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: delay InterfacePtr::Create() until you actually need an InterfacePtr. GetProxy() and ConnectToAppl… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/ui/view_provider_app.h

diff --git a/mojo/ui/view_provider_app.h b/mojo/ui/view_provider_app.h

index 07668c6de304533b2a7062838b095899c3a8dda2..de4b6b3c5bc5d51ae075b227796b23427154fd2c 100644

--- a/mojo/ui/view_provider_app.h

+++ b/mojo/ui/view_provider_app.h

@@ -46,7 +46,7 @@ class ViewProviderApp : public mojo::ApplicationDelegate,

virtual bool CreateView(

const std::string& view_provider_url,

mojo::InterfaceRequest<mojo::ServiceProvider> services,

- mojo::ServiceProviderPtr exposed_services,

+ mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,

const mojo::ui::ViewProvider::CreateViewCallback& callback) = 0;

private:

@@ -59,7 +59,7 @@ class ViewProviderApp : public mojo::ApplicationDelegate,

void CreateView(DelegatingViewProvider* provider,

const std::string& view_provider_url,

mojo::InterfaceRequest<mojo::ServiceProvider> services,

- mojo::ServiceProviderPtr exposed_services,

+ mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,

const mojo::ui::ViewProvider::CreateViewCallback& callback);

mojo::ApplicationImpl* app_impl_ = nullptr;

« mojo/ui/gl_renderer_unittest.cc ('K') | « mojo/ui/gl_renderer_unittest.cc ('k') | mojo/ui/view_provider_app.cc » ('j') | services/gfx/compositor/compositor_impl.cc » ('J')