mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: delay InterfacePtr::Create() until you actually need an InterfacePtr. GetProxy() and ConnectToAppl… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/strong_binding.h ('K') | « mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl » ('j') | mojo/ui/gl_renderer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

index 645229ff51faa68626cb35f2acf759cba4679a9e..fb88cf4abaf295a100647f45c461effa6443d44e 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

@@ -181,7 +181,8 @@

{%- endif %}

{%- elif kind|is_any_handle_kind or kind|is_interface_kind %}

{%- if kind|is_interface_kind %}

- mojo::internal::InterfacePointerToData({{input_field}}.Pass(), &{{output}}->{{name}});

+ mojo::internal::InterfaceHandleToData({{input_field}}.Pass(),

+ &{{output}}->{{name}});

viettrungluu 2016/02/11 18:26:29 nit: fix indentation

vardhan 2016/02/11 22:47:53 Done.

{%- elif kind|is_interface_request_kind %}

{{output}}->{{name}} = {{input_field}}.PassMessagePipe().release();

{%- else %}

@@ -253,7 +254,7 @@

Deserialize_({{input}}->{{name}}.ptr, &{{output_field}});

{%- endif %}

{%- elif kind|is_interface_kind %}

- mojo::internal::InterfaceDataToPointer(&{{input}}->{{name}}, &{{output_field}});

+ mojo::internal::InterfaceDataToHandle(&{{input}}->{{name}}, &{{output_field}});

{%- elif kind|is_interface_request_kind %}

{{output_field}}.Bind(mojo::MakeScopedHandle(mojo::internal::FetchAndReset(&{{input}}->{{name}})));

{%- elif kind|is_any_handle_kind %}