examples/ui/pdf_viewer/pdf_viewer.cc - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: examples/ui/pdf_viewer/pdf_viewer.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: delay InterfacePtr::Create() until you actually need an InterfacePtr. GetProxy() and ConnectToAppl… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: examples/ui/pdf_viewer/pdf_viewer.cc

diff --git a/examples/ui/pdf_viewer/pdf_viewer.cc b/examples/ui/pdf_viewer/pdf_viewer.cc

index ee760ab71f7e459a04a58558de1fcead76e76c5a..c9fa881913679e65c7bb65ec5df297e7818df656 100644

--- a/examples/ui/pdf_viewer/pdf_viewer.cc

+++ b/examples/ui/pdf_viewer/pdf_viewer.cc

@@ -259,7 +259,7 @@ class PDFContentViewProviderApp : public mojo::ui::ViewProviderApp {

bool CreateView(

const std::string& connection_url,

mojo::InterfaceRequest<mojo::ServiceProvider> services,

- mojo::ServiceProviderPtr exposed_services,

+ mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,

const mojo::ui::ViewProvider::CreateViewCallback& callback) override {

new PDFDocumentView(app_impl(), pdf_document_, callback);

return true;

« no previous file with comments | « examples/ui/noodles/noodles_app.cc ('k') | examples/ui/png_viewer/png_viewer.cc » ('j') | mojo/public/cpp/bindings/binding.h » ('J')