Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1682113002: Fix product build for 32-bit architectures, simulators and ARM64. (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix product build for 32-bit architectures, simulators and ARM64. (That's everything but X64.) R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/c5f181894074048879482547a201655f581cbc76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -19 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 3 chunks +15 lines, -3 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 3 chunks +15 lines, -3 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 3 chunks +15 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 10 months ago (2016-02-09 19:12:16 UTC) #2
Cutch
lgtm
4 years, 10 months ago (2016-02-09 19:18:48 UTC) #3
rmacnak
4 years, 10 months ago (2016-02-09 19:25:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c5f181894074048879482547a201655f581cbc76 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698