Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1682083002: Remove SkNEW_APPEND_TO_TARRAY. (Closed)

Created:
4 years, 10 months ago by bungeman-skia
Modified:
4 years, 10 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkNEW_APPEND_TO_TARRAY. The use of SkNEW_APPEND_TO_TARRAY is now better served by SkTArray::emplace_back(...) which should now be used instead. The existing users of SkNEW_APPEND_TO_TARRAY are converted and the code relating to SkNEW_APPEND_TO_TARRAY is removed. TBR=reed This only removes code. The file should also be made private. Committed: https://skia.googlesource.com/skia/+/85dc359f749c349bbd8e0ba56825b9457f654237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -39 lines) Patch
M include/core/SkTArray.h View 3 chunks +1 line, -29 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLGeometryProcessor.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682083002/1
4 years, 10 months ago (2016-02-09 18:58:16 UTC) #4
bungeman-skia
Most of the users which need to be converted are in GPU, so making bsalomon ...
4 years, 10 months ago (2016-02-09 19:03:42 UTC) #6
mtklein
lgtm
4 years, 10 months ago (2016-02-09 19:05:29 UTC) #7
bsalomon
w00t
4 years, 10 months ago (2016-02-09 19:09:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682083002/1
4 years, 10 months ago (2016-02-09 19:12:46 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 19:32:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/85dc359f749c349bbd8e0ba56825b9457f654237

Powered by Google App Engine
This is Rietveld 408576698