Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1682033002: Componentize login dialog strings (Closed)

Created:
4 years, 10 months ago by droger
Modified:
4 years, 10 months ago
CC:
achuith+watch_chromium.org, chromium-reviews, dzhioev+watch_chromium.org, tfarina, vabr+watchlistlogin_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize login dialog strings The strings are componentized to be shared with the iOS build. TBR=pkasting Committed: https://crrev.com/ac8af841fdeaee862c007c1c68ae2105efbe6477 Cr-Commit-Position: refs/heads/master@{#374632}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/login_prompt_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/login_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download
A components/login_dialog_strings.grdp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
droger
4 years, 10 months ago (2016-02-09 17:39:51 UTC) #2
sdefresne
lgtm
4 years, 10 months ago (2016-02-09 17:40:37 UTC) #3
droger
TBR=pkasting for the #include changes in chrome/browser/ui
4 years, 10 months ago (2016-02-10 10:00:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682033002/20001
4 years, 10 months ago (2016-02-10 10:01:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-02-10 10:06:13 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ac8af841fdeaee862c007c1c68ae2105efbe6477 Cr-Commit-Position: refs/heads/master@{#374632}
4 years, 10 months ago (2016-02-10 10:06:57 UTC) #13
Peter Kasting
4 years, 10 months ago (2016-02-10 12:31:20 UTC) #14
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698