Documentation cleanups.

Documentation cleanups.

BUG= http://dartbug.com/25703
BUG= http://dartbug.com/25728
BUG= http://dartbug.com/25713
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/381c12df4ade7cfe67aedd391a1896072a6fc799

[floitsch, 2016-02-09 16:16:27]

floitsch@google.com changed reviewers:
+ asgerf@google.com

[Lasse Reichstein Nielsen, 2016-02-09 16:34:52]

lrn@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-02-09 16:34:53]

lgtm

https://codereview.chromium.org/1682013002/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/1682013002/diff/1/sdk/lib/async/stream.dart#n...
sdk/lib/async/stream.dart:1383: * After this call it does no longer receive
events. However, the cleanup of
"After this call returns, the subscription no longer receives events.

The stream may need to shut down the source of events and clean up after the
subscription is cancelled."

https://codereview.chromium.org/1682013002/diff/1/sdk/lib/async/stream.dart#n...
sdk/lib/async/stream.dart:1388: * its cleanup.
I would focus on returning a future - we have many places where we return a
pre-completed future even if there is no cleanup, returning null is just the
special case that we can't get rid of.

Something like:
  Returns a future which completes after cleanup is done.
  May return `null` if there is no further cleanup.

https://codereview.chromium.org/1682013002/diff/1/sdk/lib/core/set.dart
File sdk/lib/core/set.dart (right):

https://codereview.chromium.org/1682013002/diff/1/sdk/lib/core/set.dart#newco...
sdk/lib/core/set.dart:91: * Adds [value] into the set.
into -> to

"add ... into" doesn't sound right. It's "add ... to" or "put ... into".

[floitsch, 2016-02-09 17:26:52]

https://codereview.chromium.org/1682013002/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/1682013002/diff/1/sdk/lib/async/stream.dart#n...
sdk/lib/async/stream.dart:1383: * After this call it does no longer receive
events. However, the cleanup of
On 2016/02/09 16:34:53, Lasse Reichstein Nielsen wrote:
> "After this call returns, the subscription no longer receives events.
> 
> The stream may need to shut down the source of events and clean up after the
> subscription is cancelled."
> 

Done.

https://codereview.chromium.org/1682013002/diff/1/sdk/lib/async/stream.dart#n...
sdk/lib/async/stream.dart:1388: * its cleanup.
On 2016/02/09 16:34:53, Lasse Reichstein Nielsen wrote:
> I would focus on returning a future - we have many places where we return a
> pre-completed future even if there is no cleanup, returning null is just the
> special case that we can't get rid of.
> 
> Something like:
>   Returns a future which completes after cleanup is done.
>   May return `null` if there is no further cleanup.
> 

Done.

https://codereview.chromium.org/1682013002/diff/1/sdk/lib/core/set.dart
File sdk/lib/core/set.dart (right):

https://codereview.chromium.org/1682013002/diff/1/sdk/lib/core/set.dart#newco...
sdk/lib/core/set.dart:91: * Adds [value] into the set.
On 2016/02/09 16:34:53, Lasse Reichstein Nielsen wrote:
> into -> to
> 
> "add ... into" doesn't sound right. It's "add ... to" or "put ... into".

Done.

[floitsch, 2016-02-09 17:27:19]

Description was changed from

==========
Documentation cleanups.

BUG= http://dartbug.com/25703
BUG= http://dartbug.com/25728
BUG= http://dartbug.com/25713
==========

to

==========
Documentation cleanups.

BUG= http://dartbug.com/25703
BUG= http://dartbug.com/25728
BUG= http://dartbug.com/25713
R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/381c12df4ade7cfe67aedd391a1896072a6fc799
==========

[floitsch, 2016-02-09 17:27:20]

Committed patchset #2 (id:20001) manually as
381c12df4ade7cfe67aedd391a1896072a6fc799 (presubmit successful).