Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 16820004: MIPS: Allocate generator result objects before unwinding try handlers (Closed)

Created:
7 years, 6 months ago by palfia
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Allocate generator result objects before unwinding try handlers Port r15079 (1ebdfdc6) Original commit message: When a generator suspends, it saves its state out to the heap and unwinds try handlers but doesn't pop anything off the stack. Instead it relies on no GC happening between the suspend and the return from the generator. However this was not the case: boxing the result object could cause GC, which would try to traverse the stack but would misinterpret words from unwound try handlers as heap objects. This CL changes to allocate the result objects before the suspend. It also removes the generators-iteration skip introduced in r15065. BUG= Committed: https://code.google.com/p/v8/source/detail?r=15096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -33 lines) Patch
M src/mips/full-codegen-mips.cc View 7 chunks +24 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 6 months ago (2013-06-12 19:29:09 UTC) #1
Paul Lind
lgtm
7 years, 6 months ago (2013-06-12 19:36:42 UTC) #2
palfia
7 years, 6 months ago (2013-06-12 19:41:37 UTC) #3
Message was sent while issue was closed.
Committed manually as r15096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698