Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1681973002: PlzNavigate: fix RenderFrameHostManagerTest.ConsecutiveNavigationsToSite (Closed)

Created:
4 years, 10 months ago by clamy
Modified:
4 years, 10 months ago
Reviewers:
carlosk
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: fix RenderFrameHostManagerTest.ConsecutiveNavigationsToSite The test now checks for the speculative RenderFrameHost instead of the pending one when PlzNavigate is enabled. BUG=475027 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/6250ed227b21456ea156ea1fbf3e33f1682fb870 Cr-Commit-Position: refs/heads/master@{#374684}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 2 chunks +22 lines, -8 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
clamy
@carlosk: PTAL
4 years, 10 months ago (2016-02-09 15:13:51 UTC) #4
carlosk
LGTM.
4 years, 10 months ago (2016-02-10 12:59:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681973002/1
4 years, 10 months ago (2016-02-10 14:45:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_site_isolation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isolation/builds/931)
4 years, 10 months ago (2016-02-10 14:51:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681973002/20001
4 years, 10 months ago (2016-02-10 15:35:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 18:00:08 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 18:01:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6250ed227b21456ea156ea1fbf3e33f1682fb870
Cr-Commit-Position: refs/heads/master@{#374684}

Powered by Google App Engine
This is Rietveld 408576698