Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1681953003: Revert of [turbofan] ARM: Improve AND instruction selection (Closed)

Created:
4 years, 10 months ago by martyn.capewell
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] ARM: Improve AND instruction selection (patchset #1 id:1 of https://codereview.chromium.org/1677023002/ ) Reason for revert: Possibly causing Mozilla test failures - will investigate. Original issue's description: > [turbofan] ARM: Improve AND instruction selection > > Improve instruction selector for mask and shift operations by using cheaper > instructions where possible, in preference to UBFX. > > BUG= > > Committed: https://crrev.com/53d9c12977f07f55b6f2a72128b8d02c4c857845 > Cr-Commit-Position: refs/heads/master@{#33843} TBR=bmeurer@chromium.org,jarin@chromium.org,danno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/5ac796b553db9bf2af3446dbb19476a9066c2024 Cr-Commit-Position: refs/heads/master@{#33850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -121 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +27 lines, -51 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 7 chunks +6 lines, -70 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
martyn.capewell
Created Revert of [turbofan] ARM: Improve AND instruction selection
4 years, 10 months ago (2016-02-09 15:11:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681953003/1
4 years, 10 months ago (2016-02-09 15:11:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 15:11:30 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 15:12:11 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ac796b553db9bf2af3446dbb19476a9066c2024
Cr-Commit-Position: refs/heads/master@{#33850}

Powered by Google App Engine
This is Rietveld 408576698