Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 168193003: ui: message_center and app_list tests opt into real GL NullDraw contexts (Closed)

Created:
6 years, 10 months ago by danakj
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, piman
Visibility:
Public.

Description

ui: message_center and app_list tests opt into real GL NullDraw contexts This breaks the dependency on the TestCompositor for these test suites. Once it's no longer in use by any test suite, we can remove it. These tests only compile in the compositor and ui/gl/ on non-Mac platforms, so only initialize GL there. Depends on: https://codereview.chromium.org/175093004/ R=ben@chromium.org BUG=270918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252771

Patch Set 1 #

Patch Set 2 : nulldraw-applistmessagecenter: #

Patch Set 3 : nulldraw-applistmessagecenter: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A ui/app_list/test/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/test/run_all_unittests.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
A ui/message_center/test/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/message_center/test/run_all_unittests.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
danakj
6 years, 10 months ago (2014-02-21 20:53:24 UTC) #1
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-21 21:29:16 UTC) #2
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 10 months ago (2014-02-21 21:29:16 UTC) #3
Ben Goodger (Google)
lgtm
6 years, 10 months ago (2014-02-21 21:32:12 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-21 21:37:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/168193003/10009
6 years, 10 months ago (2014-02-21 21:37:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 23:41:15 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268163
6 years, 10 months ago (2014-02-21 23:41:17 UTC) #8
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-21 23:46:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/168193003/10009
6 years, 10 months ago (2014-02-21 23:48:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/168193003/10009
6 years, 10 months ago (2014-02-22 01:28:29 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 08:09:19 UTC) #12
Message was sent while issue was closed.
Change committed as 252771

Powered by Google App Engine
This is Rietveld 408576698