Fix compositing chicken and egg problem in updateControlTints.

Fix compositing chicken and egg problem in updateControlTints.

updateControlTints reads compositingState, so it need to call the
new big hammer method that updates layout and compositing state,
updateLayoutAndStyleForPainting.

Also, move the update layout call to be inside updateControlTints
instead of FocusController::setActive so that we only do it if
we're actually on an OS that supportsControlTints.

BUG=343758
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167384

[abarth-chromium, 2014-02-15 07:12:19]

LGTM module protector nonsense

https://codereview.chromium.org/168193002/diff/1/Source/core/frame/FrameView.cpp
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/168193002/diff/1/Source/core/frame/FrameView....
Source/core/frame/FrameView.cpp:2782: {
Don't we need to hold a RefPtr<FrameView> protector here?  Can't updating layout
run script and tear down the world?

https://codereview.chromium.org/168193002/diff/1/Source/web/PageWidgetDelegat...
File Source/web/PageWidgetDelegate.cpp (left):

https://codereview.chromium.org/168193002/diff/1/Source/web/PageWidgetDelegat...
Source/web/PageWidgetDelegate.cpp:71: RefPtr<FrameView> view =
mainFrameView(page);
Notice the RefPtr here

[ojan, 2014-02-18 18:52:40]

Added protectors.

https://codereview.chromium.org/168193002/diff/1/Source/core/frame/FrameView.cpp
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/168193002/diff/1/Source/core/frame/FrameView....
Source/core/frame/FrameView.cpp:2782: {
On 2014/02/15 07:12:19, abarth wrote:
> Don't we need to hold a RefPtr<FrameView> protector here?  Can't updating
layout
> run script and tear down the world?

:(

[ojan, 2014-02-18 18:52:44]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-02-18 18:52:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ojan@chromium.org/168193002/90001

[commit-bot: I haz the power, 2014-02-18 21:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-18 21:43:34]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[abarth-chromium, 2014-02-18 21:46:41]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-02-18 21:46:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ojan@chromium.org/168193002/90001

[commit-bot: I haz the power, 2014-02-19 00:36:24]

Change committed as 167384

[dstockwell, 2014-02-19 05:35:50]

A revert of this CL has been created in
https://codereview.chromium.org/170803010/ by dstockwell@chromium.org.

The reason for reverting is: Appears to cause a number of virtual/threaded tests
to time out on windows.

See:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40....