PPAPI: Introduce PPB_NetworkProxy_Dev

ppapi/proxy/network_proxy_resource.cc

Index: ppapi/proxy/network_proxy_resource.cc
diff --git a/ppapi/proxy/network_proxy_resource.cc b/ppapi/proxy/network_proxy_resource.cc
new file mode 100644
index 0000000000000000000000000000000000000000..76dd5ffba6a98d3c87b99763651cffcaa9f8777d
--- /dev/null
+++ b/ppapi/proxy/network_proxy_resource.cc
@@ -0,0 +1,63 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ppapi/proxy/network_proxy_resource.h"
+
+#include "base/bind.h"
+#include "ppapi/proxy/dispatch_reply_message.h"
+#include "ppapi/proxy/ppapi_messages.h"
+#include "ppapi/shared_impl/var.h"
+
+namespace ppapi {
+namespace proxy {
+
+NetworkProxyResource::NetworkProxyResource(Connection connection,
+                                           PP_Instance instance)
+    : PluginResource(connection, instance) {
+  SendCreate(BROWSER, PpapiHostMsg_NetworkProxy_Create());
+}
+
+NetworkProxyResource::~NetworkProxyResource() {
+}
+
+thunk::PPB_NetworkProxy_API* NetworkProxyResource::AsPPB_NetworkProxy_API() {
+  return this;
+}
+
+int32_t NetworkProxyResource::GetProxyForURL(
+      PP_Instance /* instance */,
+      PP_Var url,
+      PP_Var* proxy_string,
+      scoped_refptr<TrackedCallback> callback) {
+  StringVar* string_url = StringVar::FromPPVar(url);
+  if (!string_url)
+    return PP_ERROR_BADARGUMENT;
+  Call<PpapiPluginMsg_NetworkProxy_GetProxyForURLReply>(
+      BROWSER,
+      PpapiHostMsg_NetworkProxy_GetProxyForURL(string_url->value()),
+      base::Bind(&NetworkProxyResource::OnPluginMsgGetProxyForURLReply,
+                 this,

[yzshen1, 2013/06/16 23:49:53]

nit, optional: It is safe and more clear to use base::Unretained(this). Because
this callback is stored in the base class of NetworkProxyResource. (Although it
also works to use |this| because we explicitly clear callbacks when all plugin
references go away.)

[dmichael (off chromium), 2013/06/17 21:48:28]

Done, thanks for pointing that out.

+                 base::Unretained(proxy_string),
+                 callback));
+  return PP_OK_COMPLETIONPENDING;
+}
+
+void NetworkProxyResource::OnPluginMsgGetProxyForURLReply(
+    PP_Var* proxy_string_out_param,
+    scoped_refptr<TrackedCallback> callback,
+    const ResourceMessageReplyParams& params,
+    const std::string& proxy_string) {
+  // If the last plugin ref for this resource was released, the callback will
+  // have been cancelled. We can't invoke it, and we can't write to the var.
+  if (!TrackedCallback::IsPending(callback))
+    return;

[dmichael (off chromium), 2013/06/17 21:48:28]

So I guess that means I don't need this check. Since PluginResource clears all
its callbacks when the last plugin ref is deleted, we should never get here with
a callback that's not pending. Turned in to a DCHECK.

+
+  if (params.result() == PP_OK) {
+    *proxy_string_out_param = (new StringVar(proxy_string))->GetPPVar();
+  }
+  callback->Run(params.result());
+}
+
+}  // namespace proxy
+}  // namespace ppapi