PPAPI: Introduce PPB_NetworkProxy_Dev

ppapi/proxy/network_proxy_resource.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_PROXY_NETWORK_PROXY_RESOURCE_H_
+#define PPAPI_PROXY_NETWORK_PROXY_RESOURCE_H_
+
+#include "ppapi/proxy/plugin_resource.h"
+#include "ppapi/proxy/ppapi_proxy_export.h"
+#include "ppapi/thunk/ppb_network_proxy_api.h"
+
+namespace ppapi {
+namespace proxy {
+
+// The proxy-side resource for PPB_NetworkProxy.
+class PPAPI_PROXY_EXPORT NetworkProxyResource
+      : public PluginResource,
+        public thunk::PPB_NetworkProxy_API {
+ public:
+  NetworkProxyResource(Connection connection, PP_Instance instance);
+  virtual ~NetworkProxyResource();
+
+ private:
+  // Resource implementation.
+  virtual thunk::PPB_NetworkProxy_API* AsPPB_NetworkProxy_API() OVERRIDE;

[yzshen1, 2013/06/16 23:49:53]

nit: both of these two virtual methods are public in the base classes. It seems
better to still make them public, because when we call them with base class
pointers, them are public anyway.

[dmichael (off chromium), 2013/06/17 21:48:28]

I subscribe to the philosophy of using the lowest visibility necessary. I like
that you can tell that the method is only ever called via the base class. This
has come up on chromium-dev before with differing opinions. Unfortunately, in
Pepper we're not very consistent right now. But I usually try to encourage least
privelege when I'm reviewing :)
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/MkBEHBx3g_4/n-KkC...

We should sync up so we're reviewing consistently. WDYT?

[yzshen1, 2013/06/18 04:41:26]

Okay. I am fine if this is well-thought-out. I previously had the same point of
view as Ryan's (in the mail thread you linked to).

On 2013/06/17 21:48:28, dmichael wrote:

+
+  // PPB_NetworkProxy_API implementation.
+  virtual int32_t GetProxyForURL(
+      PP_Instance instance,
+      PP_Var url,
+      PP_Var* proxy_string,
+      scoped_refptr<TrackedCallback> callback) OVERRIDE;
+
+  void OnPluginMsgGetProxyForURLReply(PP_Var* proxy_string_out_param,
+                                      scoped_refptr<TrackedCallback> callback,
+                                      const ResourceMessageReplyParams& params,
+                                      const std::string& proxy_string);
+
+  DISALLOW_COPY_AND_ASSIGN(NetworkProxyResource);
+};
+
+}  // namespace proxy
+}  // namespace ppapi
+
+#endif  // PPAPI_PROXY_NETWORK_PROXY_RESOURCE_H_