[regexp] parse RegExpUnicodeEscapeSequence according to spec.

[regexp] parse RegExpUnicodeEscapeSequence according to spec.

See http://tc39.github.io/ecma262/#prod-RegExpUnicodeEscapeSequence

R=erik.corry@gmail.com, erikcorry@chromium.org
BUG=v8:2952
LOG=N

Committed: https://crrev.com/42309697c1da440e9b646c0093a54c106ec7b693
Cr-Commit-Position: refs/heads/master@{#33892}

[Yang, 2016-02-09 16:23:23]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-09 16:23:26]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2016-02-09 16:23:30]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 16:23:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681893002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681893002/1

[commit-bot: I haz the power, 2016-02-09 16:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 16:37:53]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[Yang, 2016-02-09 19:18:31]

https://codereview.chromium.org/1681893002/diff/20001/src/regexp/regexp-parse...
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/1681893002/diff/20001/src/regexp/regexp-parse...
src/regexp/regexp-parser.cc:903: if (current() < '0' || current() > '9') return
0;
This now matches how we parse \<digit> outside of a character class.

[Yang, 2016-02-09 19:18:36]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 19:18:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681893002/20001

[commit-bot: I haz the power, 2016-02-09 19:58:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 19:58:28]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-02-10 06:11:50]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 06:11:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681893002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681893002/60001

[commit-bot: I haz the power, 2016-02-10 06:59:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 06:59:26]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-02-11 09:03:05]

littledan@chromium.org changed reviewers:
+ littledan@chromium.org

[Dan Ehrenberg, 2016-02-11 09:07:51]

lgtm

So strange that the spec has this syntax for a lead/trail pair! But this looks
like a correct implementation.

https://codereview.chromium.org/1681893002/diff/60001/test/mjsunit/harmony/un...
File test/mjsunit/harmony/unicode-escapes-in-regexps.js (right):

https://codereview.chromium.org/1681893002/diff/60001/test/mjsunit/harmony/un...
test/mjsunit/harmony/unicode-escapes-in-regexps.js:277: assertNull(new
RegExp("[\\ud800\udc00]", "u").exec("\u{10000}"));
Optional: Comments about what this is testing are nice, as you did in the other
new tests.

https://codereview.chromium.org/1681893002/diff/60001/test/mjsunit/harmony/un...
File test/mjsunit/harmony/unicode-regexp-restricted-syntax.js (right):

https://codereview.chromium.org/1681893002/diff/60001/test/mjsunit/harmony/un...
test/mjsunit/harmony/unicode-regexp-restricted-syntax.js:39:
assertThrows("/[\\00]/u");
Optional: Assert it throws a SyntaxError?

[Yang, 2016-02-11 12:02:36]

https://codereview.chromium.org/1681893002/diff/60001/test/mjsunit/harmony/un...
File test/mjsunit/harmony/unicode-escapes-in-regexps.js (right):

https://codereview.chromium.org/1681893002/diff/60001/test/mjsunit/harmony/un...
test/mjsunit/harmony/unicode-escapes-in-regexps.js:277: assertNull(new
RegExp("[\\ud800\udc00]", "u").exec("\u{10000}"));
On 2016/02/11 09:07:51, Dan Ehrenberg wrote:
> Optional: Comments about what this is testing are nice, as you did in the
other
> new tests.

Done.

https://codereview.chromium.org/1681893002/diff/60001/test/mjsunit/harmony/un...
File test/mjsunit/harmony/unicode-regexp-restricted-syntax.js (right):

https://codereview.chromium.org/1681893002/diff/60001/test/mjsunit/harmony/un...
test/mjsunit/harmony/unicode-regexp-restricted-syntax.js:39:
assertThrows("/[\\00]/u");
On 2016/02/11 09:07:51, Dan Ehrenberg wrote:
> Optional: Assert it throws a SyntaxError?

Done.

[Yang, 2016-02-11 12:02:40]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-11 12:02:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1681893002/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-02-11 12:02:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681893002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681893002/80001

[commit-bot: I haz the power, 2016-02-11 12:02:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681893002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681893002/80001

[commit-bot: I haz the power, 2016-02-11 12:28:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-11 12:29:37]

Description was changed from

==========
[regexp] parse RegExpUnicodeEscapeSequence according to spec.

See http://tc39.github.io/ecma262/#prod-RegExpUnicodeEscapeSequence

R=erik.corry@gmail.com, erikcorry@chromium.org
BUG=v8:2952
LOG=N
==========

to

==========
[regexp] parse RegExpUnicodeEscapeSequence according to spec.

See http://tc39.github.io/ecma262/#prod-RegExpUnicodeEscapeSequence

R=erik.corry@gmail.com, erikcorry@chromium.org
BUG=v8:2952
LOG=N

Committed: https://crrev.com/42309697c1da440e9b646c0093a54c106ec7b693
Cr-Commit-Position: refs/heads/master@{#33892}
==========

[commit-bot: I haz the power, 2016-02-11 12:29:37]

Patchset 5 (id:??) landed as
https://crrev.com/42309697c1da440e9b646c0093a54c106ec7b693
Cr-Commit-Position: refs/heads/master@{#33892}