Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1681873002: [regexp] fix off-by-one in UnicodeRangeSplitter. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] fix off-by-one in UnicodeRangeSplitter. R=bmeurer@chromium.org Committed: https://crrev.com/5082eaee5f75673b6ebef655045b24c7402ffe4c Cr-Commit-Position: refs/heads/master@{#33837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/regexp/jsregexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/unicode-character-ranges.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 10 months ago (2016-02-09 08:16:09 UTC) #1
Benedikt Meurer
lgtm
4 years, 10 months ago (2016-02-09 08:16:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681873002/1
4 years, 10 months ago (2016-02-09 08:20:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 09:09:57 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 09:10:45 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5082eaee5f75673b6ebef655045b24c7402ffe4c
Cr-Commit-Position: refs/heads/master@{#33837}

Powered by Google App Engine
This is Rietveld 408576698