Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: chrome/browser/ui/cocoa/browser_window_command_handler.mm

Issue 1681863005: Added the "Show as Tab" option for popups on OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_command_handler.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_command_handler.mm b/chrome/browser/ui/cocoa/browser_window_command_handler.mm
index 4f88b46e4ff48c3a000a95af8e37fbb3a2a80d5f..78c125eb7db200b31e660c5d89fdfc6ddd5ca327 100644
--- a/chrome/browser/ui/cocoa/browser_window_command_handler.mm
+++ b/chrome/browser/ui/cocoa/browser_window_command_handler.mm
@@ -220,6 +220,11 @@ Browser* FindBrowserForSender(id sender, NSWindow* window) {
enable = NO;
}
}
+ case IDC_SHOW_AS_TAB: {
+ // Hide this menu option if the window is tabbed.
+ NSMenuItem* menuItem = base::mac::ObjCCast<NSMenuItem>(item);
+ [menuItem setHidden:browser->is_type_tabbed()];
erikchen 2016/02/10 03:13:13 Missing break for this case, and the one above it?
spqchan 2016/02/10 17:27:06 Done.
+ }
default:
// Special handling for the contents of the Text Encoding submenu. On
// Mac OS, instead of enabling/disabling the top-level menu item, we
« chrome/browser/app_controller_mac.mm ('K') | « chrome/browser/app_controller_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698