Issue 1681863003: dart2js: Distinguish precedence levels for left-hand side and call.

Issue 1681863003: dart2js: Distinguish precedence levels for left-hand side and call. (Closed)

Created:
4 years, 10 months ago by asgerf

Modified:
4 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: Distinguish precedence levels for left-hand side and call. This fixes an issue where `new (f())()` was emitted as `new f()()`. This in turn fixes some JS interop issues in the CPS backend. CLOSES #25708 BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ba582b48b359bd193ecf643515176f827a9452e7

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -15 lines)			Patch
M	pkg/js_ast/lib/src/nodes.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/js_ast/lib/src/precedence.dart	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	pkg/js_ast/lib/src/printer.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/html/html.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

Siggi Cherem (dart-lang)

Also, could you update the two expectations in the html.status file? Thanks!

4 years, 10 months ago (2016-02-09 15:19:31 UTC) #4

asgerf

Done. I was wondering why I didn't see any new tests passing - I forgot ...

4 years, 10 months ago (2016-02-09 15:52:37 UTC) #5

asgerf

4 years, 10 months ago (2016-02-09 16:15:09 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ba582b48b359bd193ecf643515176f827a9452e7 (presubmit successful).