Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1681863002: Fix for-loop which results in no-op (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
hashimoto
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for-loop which results in no-op The existing code (added in https://codereview.chromium.org/1650793002/) changes the state of a copy of the object. Original CL: https://codereview.chromium.org/1679783002/ Original Author: hashimoto@chromium.org R=hashimoto@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/56cf589f6ecc85a84c183956bdcb071ec16567d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
4 years, 10 months ago (2016-02-09 06:21:17 UTC) #2
hashimoto
thanks, lgtm
4 years, 10 months ago (2016-02-09 07:46:01 UTC) #3
Lei Zhang
4 years, 10 months ago (2016-02-09 07:46:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56cf589f6ecc85a84c183956bdcb071ec16567d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698