Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1681853002: Find and serialize other libraries next to the libraries described in libraries.dart meta. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Find and serialize other libraries next to the libraries described in libraries.dart meta. Even while these libraries are not descibed directly in the libraries.dart file of Dart SDK, they still can be imported using URIs like 'dart:html_common/metadata.dart'. So, we need to serialize them too. Unfortunately I don't see any direct way to know all the SDK libraries. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7f4f8f07a50a70908c4d42a20050284205244089

Patch Set 1 #

Patch Set 2 : Walk imports/exports instead of file system. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -50 lines) Patch
M pkg/analyzer/tool/summary/build_sdk_summaries.dart View 1 2 chunks +83 lines, -50 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
scheglov
4 years, 10 months ago (2016-02-09 05:41:36 UTC) #1
Brian Wilkerson
Couldn't we just follow imports? Nothing in the SDK can import anything that isn't in ...
4 years, 10 months ago (2016-02-09 14:21:27 UTC) #2
scheglov
On 2016/02/09 14:21:27, Brian Wilkerson wrote: > Couldn't we just follow imports? Nothing in the ...
4 years, 10 months ago (2016-02-09 17:05:47 UTC) #3
Brian Wilkerson
LGTM https://codereview.chromium.org/1681853002/diff/20001/pkg/analyzer/tool/summary/build_sdk_summaries.dart File pkg/analyzer/tool/summary/build_sdk_summaries.dart (right): https://codereview.chromium.org/1681853002/diff/20001/pkg/analyzer/tool/summary/build_sdk_summaries.dart#newcode65 pkg/analyzer/tool/summary/build_sdk_summaries.dart:65: final String sdkPath; As a future enhancement, we'll ...
4 years, 10 months ago (2016-02-09 17:16:40 UTC) #4
Paul Berry
lgtm
4 years, 10 months ago (2016-02-09 18:23:16 UTC) #5
scheglov
4 years, 10 months ago (2016-02-09 20:26:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7f4f8f07a50a70908c4d42a20050284205244089 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698