scripts/slave/recipes/deterministic_build.py - Issue 1681833002: Removes dont_embed_build_metadata in preparation for its removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/deterministic_build.py

Issue 1681833002: Removes dont_embed_build_metadata in preparation for its removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium/config.py ('k') | scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_linux_deterministic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/deterministic_build.py

diff --git a/scripts/slave/recipes/deterministic_build.py b/scripts/slave/recipes/deterministic_build.py

index cfc9b89160c0a045d590f499820e61ed48040896..bebe3a7d79b2cbcc351593f67652b666237b0c3c 100644

--- a/scripts/slave/recipes/deterministic_build.py

+++ b/scripts/slave/recipes/deterministic_build.py

@@ -64,7 +64,6 @@ def ConfigureChromiumBuilder(api, recipe_config):

api.chromium.set_config(recipe_config['chromium_config'],

**recipe_config.get('chromium_config_kwargs',

{'BUILD_CONFIG': 'Release'}))

- api.chromium.apply_config('chromium_deterministic_build')

api.gclient.set_config(recipe_config['gclient_config'],

**recipe_config.get('gclient_config_kwargs', {}))