chrome/browser/resources/chromeos/arc_opt_in/main.html - Issue 1681813003: arc: Use incognito profile for OptIn and cookie fetcher

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/arc_opt_in/main.html

Issue 1681813003: arc: Use incognito profile for OptIn and cookie fetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/arc_opt_in/background.js ('K') | « chrome/browser/resources/chromeos/arc_opt_in/background.js ('k') | chrome/browser/resources/chromeos/arc_opt_in/manifest.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html style="width:100%; height:100%">
	xiyuan 2016/02/11 17:57:21 Inline css is not recommended. Please move them in Inline css is not recommended. Please move them into a <style> tag or a .css flie <head> <style> html, body, webview { height: 100%; margin: 0; padding: 0; width: 100%; } </style> </head> khmel 2016/02/12 02:45:24 Nice code. My html is not so good as wanted. Show quoted text On 2016/02/11 17:57:21, xiyuan wrote: > Inline css is not recommended. Please move them into a <style> tag or a .css > flie > > <head> > <style> > html, > body, > webview { > height: 100%; > margin: 0; > padding: 0; > width: 100%; > } > </style> > </head> Nice code. My html is not so good as wanted.
	3 <head>

	4 </head>

	5 <body style="width:100%; height:100%">

	6 <webview

	7 id="arc_opt_in"

	8 partition="persist:arc_opt_in"

	9 style="width:100%; height:100%"

	10 src="https://accounts.google.com/o/oauth2/programmatic_auth?scope=https://ww w.google.com/accounts/OAuthLogin&client_id=1070009224336-sdh77n7uot3oc99ais00jmu ft6sk2fg9.apps.googleusercontent.com">
	xiyuan 2016/02/11 17:57:21 Do we need to have "hl" URL param so that the page Do we need to have "hl" URL param so that the page is displayed in the correct language? khmel 2016/02/12 02:45:24 It seems, it can resolve lang automatically. I see Show quoted text On 2016/02/11 17:57:21, xiyuan wrote: > Do we need to have "hl" URL param so that the page is displayed in the correct > language? It seems, it can resolve lang automatically. I see different languages on diff devices. Particular in my recent tests it was shown in Russian lang . xiyuan 2016/02/12 17:06:59 Okay. We can leave it for now but I suspect we mig Show quoted text On 2016/02/12 02:45:24, khmel wrote: > On 2016/02/11 17:57:21, xiyuan wrote: > > Do we need to have "hl" URL param so that the page is displayed in the correct > > language? > > It seems, it can resolve lang automatically. I see different languages on diff > devices. Particular in my recent tests it was shown in Russian lang . Okay. We can leave it for now but I suspect we might need to revisit this later. khmel 2016/02/12 18:15:14 Acknowledged. Show quoted text On 2016/02/12 17:06:59, xiyuan wrote: > On 2016/02/12 02:45:24, khmel wrote: > > On 2016/02/11 17:57:21, xiyuan wrote: > > > Do we need to have "hl" URL param so that the page is displayed in the > correct > > > language? > > > > It seems, it can resolve lang automatically. I see different languages on diff > > devices. Particular in my recent tests it was shown in Russian lang . > > Okay. We can leave it for now but I suspect we might need to revisit this later. Acknowledged.
	11 </webview>

	12 </body>

	13 </html>

OLD	NEW